Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: PATCH: zle TODOs etc.
- X-seq: zsh-workers 21065
- From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- To: Zsh hackers list <zsh-workers@xxxxxxxxxx>
- Subject: Re: PATCH: zle TODOs etc.
- Date: Sat, 26 Mar 2005 17:14:22 +0000
- In-reply-to: <20050323003652.GA11877@xxxxxxxxxxx>
- Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
- References: <20050321013910.GA32327@xxxxxxxxxxx> <1050321020913.ZM11750@xxxxxxxxxxxxxxxxxxxxxxx> <200502251446.j1PEkID6019392@xxxxxxxxxxxxxx> <20050323003652.GA11877@xxxxxxxxxxx>
On Mar 22, 7:36pm, Clint Adams wrote:
}
} Is this the right way to go about this?
}
} +mod_export void
} +wordcharshook(void)
It looks OK to me, though you should probably wait for another opinion,
as I'm not really the expert on this part of the code (maybe no one is).
Two comments:
I suggest avoiding the term "hook" in this context, because that has a
specific meaning in the zsh code (see the HOOKDEF macro) and tweaking
the value of wordchars really doesn't fit that usage.
I'd move the assignment from the /* Set up editor entry points */ section
down to the /* miscellaneous initialisations */ section, as you're not
really defining a new entry point.
Messages sorted by:
Reverse Date,
Date,
Thread,
Author