Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: Slightly improve test harness

On Mon, Aug 08, 2005 at 08:23:54PM +0200, Thorsten Dahlheimer wrote:
> - don't abort the test run if a testcase fails (unless there's a syntax
>   error in the test file)

That change results in an erroneous "Test successful" message when a
test fails and verbosity is at least 1.  Did you check if any of the
test cases expected the success of an earlier test in a later test?
If so, it might be best to just leave the abort-after-the-first-failure
behavior unchanged.

> - make sure cleanup is always performed when exiting

That fixed trap code seems to make it impossible to Ctrl-C out of the
tests, though I'm not sure why yet.  Perhaps it's a bug in trap
handling, but zsh hangs when that cleanup trap in place and Ctrl-C is

In the meantime, I've checked in a change that just disables the trap
line (since zsh now complains about its incorrect syntax).


Messages sorted by: Reverse Date, Date, Thread, Author