Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: PATCH: Slightly improve test harness
- X-seq: zsh-workers 21586
- From: Wayne Davison <wayned@xxxxxxxxxxxxxxxxxxxxx>
- To: Thorsten Dahlheimer <tdahlheim@xxxxxxx>
- Subject: Re: PATCH: Slightly improve test harness
- Date: Tue, 9 Aug 2005 00:39:27 -0700
- Cc: zsh-workers@xxxxxxxxxx
- In-reply-to: <028601c59c46$56d0dea0$cc74fea9@pcdahl4201>
- Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
- References: <028601c59c46$56d0dea0$cc74fea9@pcdahl4201>
On Mon, Aug 08, 2005 at 08:23:54PM +0200, Thorsten Dahlheimer wrote:
> - don't abort the test run if a testcase fails (unless there's a syntax
> error in the test file)
That change results in an erroneous "Test successful" message when a
test fails and verbosity is at least 1. Did you check if any of the
test cases expected the success of an earlier test in a later test?
If so, it might be best to just leave the abort-after-the-first-failure
behavior unchanged.
> - make sure cleanup is always performed when exiting
That fixed trap code seems to make it impossible to Ctrl-C out of the
tests, though I'm not sure why yet. Perhaps it's a bug in trap
handling, but zsh hangs when that cleanup trap in place and Ctrl-C is
pressed.
In the meantime, I've checked in a change that just disables the trap
line (since zsh now complains about its incorrect syntax).
..wayne..
Messages sorted by:
Reverse Date,
Date,
Thread,
Author