Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: shorthand for splitting on null bytes.

X-seq: zsh-workers 22376
From: Wayne Davison <wayned@xxxxxxxxxxxxxxxxxxxxx>
To: Peter Stephenson <pws@xxxxxxx>
Subject: Re: PATCH: shorthand for splitting on null bytes.
Date: Wed, 22 Mar 2006 10:21:48 -0800
Cc: Zsh hackers list <zsh-workers@xxxxxxxxxx>
In-reply-to: <EXCHANGE032duiiQ03F00001d18@xxxxxxxxxxxxxxxxxx>
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
References: <EXCHANGE032duiiQ03F00001d18@xxxxxxxxxxxxxxxxxx>

On Wed, Mar 22, 2006 at 12:06:54PM +0000, Peter Stephenson wrote:
> Any comments?

Just a comment on the obfuscationality :-) of one line in your patch:

> +		    spsep[0] = Meta;
> +		    spsep[1] = ' ';

I'd rather see that last line be "spsep[1] = '\0' ^ 32;" because that
makes the value a little clearer (the end result is obviously the same).

..wayne..

References:
- PATCH: shorthand for splitting on null bytes.
  - From: Peter Stephenson

Messages sorted by: Reverse Date, Date, Thread, Author