Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: fg call in function: bug?
- X-seq: zsh-workers 22971
- From: Peter Stephenson <pws@xxxxxxx>
- To: zsh-workers@xxxxxxxxxx
- Subject: Re: fg call in function: bug?
- Date: Mon, 6 Nov 2006 12:27:10 +0000
- In-reply-to: <17393e3e0611031715m7a189c43t46f5b0807490f129@xxxxxxxxxxxxxx>
- Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
- Organization: Cambridge Silicon Radio
- References: <17393e3e0611031715m7a189c43t46f5b0807490f129@xxxxxxxxxxxxxx>
"Matt Wozniski" <godlygeek@xxxxxxxxx> wrote:
> Ok, I have an even weirder test case for the "job control in cursh
> construct" bug... No arguments, %-, %+, and even %2 work as expected,
> but %1 doesn't?
>
> ~>{ jobs %1 }
> ~>jobs %1
> jobs: %1: no such job
Just to complete the story... "jobs" on its own is simply a builtin and
doesn't cause the special logic to create a pseudojob, while in braces it
becomes a construct that gets special handling. It's usually job 1 because that's
the first that's free; as it's special it doesn't cause %- or %+ to be set.
This is fixed by the patch that I just posted, but I noticed that the form
of error is different for no good reason, so I'll put that right, too.
Index: Src/exec.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/exec.c,v
retrieving revision 1.104
diff -u -r1.104 exec.c
--- Src/exec.c 17 Sep 2006 19:28:46 -0000 1.104
+++ Src/exec.c 6 Nov 2006 12:24:04 -0000
@@ -2265,7 +2265,7 @@
/* This is a current shell procedure that didn't need to fork. *
* This includes current shell procedures that are being exec'ed, *
* as well as null execs. */
- jobtab[thisjob].stat |= STAT_CURSH;
+ jobtab[thisjob].stat |= STAT_CURSH|STAT_NOPRINT;
} else {
/* This is an exec (real or fake) for an external command. *
* Note that any form of exec means that the subshell is fake *
Index: Src/jobs.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/jobs.c,v
retrieving revision 1.49
diff -u -r1.49 jobs.c
--- Src/jobs.c 3 Nov 2006 19:44:47 -0000 1.49
+++ Src/jobs.c 6 Nov 2006 12:24:05 -0000
@@ -1771,7 +1771,7 @@
}
if (!(jobtab[job].stat & STAT_INUSE) ||
(jobtab[job].stat & STAT_NOPRINT)) {
- zwarnnam(name, "no such job: %d", job);
+ zwarnnam(name, "%%%d: no such job", job);
unqueue_signals();
return 1;
}
--
Peter Stephenson <pws@xxxxxxx> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
To access the latest news from CSR copy this link into a web browser: http://www.csr.com/email_sig.php
Messages sorted by:
Reverse Date,
Date,
Thread,
Author