Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: NULL-Pointer dereference in complist.c

X-seq: zsh-workers 23145
From: Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>
To: zsh-workers@xxxxxxxxxx
Subject: Re: PATCH: NULL-Pointer dereference in complist.c
Date: Fri, 02 Feb 2007 23:50:16 +0000
In-reply-to: Message from Felix Eckhofer <felix@xxxxxxxxx> of "Fri, 02 Feb 2007 23:45:11 +0100." <200702022345.29023.felix@xxxxxxxxx>
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm

Felix Eckhofer wrote:
> However, I was quickly able to reproduce a segfault on my machine
> (Ubuntu 6.10, zsh 4.3.2-13ubuntu1, x86_64). It happens, because at
> complist.c:1848 s =3D=3D NULL. I wasn't able to understand completely what
> happens but the attached patch works for me and seems reasonable.
> 
> Unfortunately, CVS seems down for the moment so I couldn't check whether
> this is already fixed in HEAD. If it is, ignore me :)

There's no corresponding fix yet, but the code is pretty much the same at
that point, so, although I couldn't get it to happen with a short play,
I applied your patch, which certainly looks unproblematic.  Thanks.

-- 
Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/

References:
- PATCH: NULL-Pointer dereference in complist.c
  - From: Felix Eckhofer

Messages sorted by: Reverse Date, Date, Thread, Author