Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: Quoting problem and crashes with ${(#)var}
- X-seq: zsh-workers 23192
- From: Peter Stephenson <pws@xxxxxxx>
- To: zsh-workers@xxxxxxxxxx
- Subject: Re: Quoting problem and crashes with ${(#)var}
- Date: Mon, 26 Feb 2007 16:24:15 +0000
- In-reply-to: <070226081332.ZM9904@xxxxxxxxxxxxxxxxxxxxxx>
- Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
- References: <200702132111.l1DLB5rA003849@xxxxxxxxxxxxxxxxx> <070213234815.ZM5424@xxxxxxxxxxxxxxxxxxxxxx> <200702141016.l1EAGpKF016735@xxxxxxxxxxxxxx> <070214080347.ZM26428@xxxxxxxxxxxxxxxxxxxxxx> <20070214161951.e8219d6c.pws@xxxxxxx> <070225151543.ZM32724@xxxxxxxxxxxxxxxxxxxxxx> <200702261034.l1QAY1fs004257@xxxxxxxxxxxxxx> <070226081332.ZM9904@xxxxxxxxxxxxxxxxxxxxxx>
Bart Schaefer wrote:
> } > + *widthp = strlen(buf);
> }
> } If printeightbit is set, then nicechar() may pass 8-bit characters,
> } which may be metafied, straight through, so ztrlen() is probably better.
> } printeightbit doesn't guaranteed to get character lengths right, but
> } counting metafied characters as 1 is more consistent.
>
> That may be more consistent, but a bit later on the same function computes
> (*swidep = buf + *widthp) so I think what's wanted here is the actual
> width rather than the visible width.
That's true for swidep, it needs to point (in this case) to the NULL at
then end (as there's not wide character following). However, *widthp
does need to be ztrlen(). So I think it they need to be separate.
(Before that nicechar() was added there couldn't be any metafied
characters at this point.)
pws
To access the latest news from CSR copy this link into a web browser: http://www.csr.com/email_sig.php
To get further information regarding CSR, please visit our Investor Relations page at http://ir.csr.com/csr/about/overview
Messages sorted by:
Reverse Date,
Date,
Thread,
Author