Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: Contributing with Completions

X-seq: zsh-workers 23692
From: "Renato Botelho" <rbgarga@xxxxxxxxx>
To: zsh-workers@xxxxxxxxxx
Subject: Re: Contributing with Completions
Date: Sun, 22 Jul 2007 12:34:55 -0300
Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=iqBZw2NV7JRGiXNvAlP6eWi30iJMHjTQ8+m21YbqnIyNfCXigGX8ZVsKO9ts29Y/YipSjUMH8RF2lGwAT5dJ4Nc2WOWqGXdsz0PaHKBkcEIFo7chZPWBNqOHmP1UT0YRQbz3PwvhSvD1Qj8oV/IfZr2m3HuxDXWPFP3q09TWEhQ=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=trvL0HBD558/h4prkmCMhQvDzys9/1FGRnpIiA6FOPInO5YjuvcvJwZm+o9DYf6Su1AswrvJMPUJ9OEkPHxndCRVS7Rg50AdBPZKCuL4/ijF5khWxBLN3FeYp6Tou18IiJV1lBFyVWWpjS3BKNTAqkAptiMv9PXTQqJ3bMxaYt8=
In-reply-to: <20070722113455.GA4684@xxxxxxxxxxx>
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
References: <747dc8f30707180650k7159c9a5lb9c3b743cbab9506@xxxxxxxxxxxxxx> <200707190437.l6J4bcLG031432@xxxxxxxxxxxxxx> <747dc8f30707190601v40917b5erdeb07e604d5d5fb4@xxxxxxxxxxxxxx> <20070722113455.GA4684@xxxxxxxxxxx>

On 7/22/07, Clint Adams <clint@xxxxxxx> wrote:

On Thu, Jul 19, 2007 at 10:01:34AM -0300, Renato Botelho wrote:
> _portsnap -> Tool for get/update FreeBSD ports tree using snapshots
>
> Comments, suggestions, critics are welcome, like I said, these are my
> first lines in zsh since i'm using it for less than a week.

When you use ->state, you should declare the scope of the parameters
context, state, line, opt_args.

Index: Completion/BSD/Command/_portsnap
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/BSD/Command/_portsnap,v
retrieving revision 1.1
diff -u -r1.1 _portsnap
--- Completion/BSD/Command/_portsnap    20 Jul 2007 16:39:15 -0000      1.1
+++ Completion/BSD/Command/_portsnap    22 Jul 2007 11:12:05 -0000
@@ -1,5 +1,8 @@
 #compdef portsnap

+local context state line
+typeset -A opt_args
+
 flags=(
   '(cron)fetch[Fetch a compressed snapshot or update existing one]'
   '(fetch)cron[Sleep rand(3600) seconds, and then fetch updates]'
@@ -17,7 +20,7 @@
     '-s:Server from which to fetch updates:_hosts' \
     '*:principal:->principal' && ret=0

-if [[ $state = principal ]]; then
+if [[ $state == principal ]]; then
   _alternative \
     ':file flag:_values -S " " -w "commands" $flags[@]' \
     '*:path:_files -/'


Thanks

--
Renato Botelho

References:
- Contributing with Completions
  - From: Renato Botelho
- Re: Contributing with Completions
  - From: Peter Stephenson
- Re: Contributing with Completions
  - From: Renato Botelho
- Re: Contributing with Completions
  - From: Clint Adams

Messages sorted by: Reverse Date, Date, Thread, Author