Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
PATCH: _git space pollution
- X-seq: zsh-workers 23862
- From: Clint Adams <clint@xxxxxxx>
- To: zsh-workers@xxxxxxxxxx
- Subject: PATCH: _git space pollution
- Date: Sun, 30 Sep 2007 07:12:26 -0400
- Mail-followup-to: zsh-workers@xxxxxxxxxx
- Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
This parameter is used exactly twice, immediately after its assignment.
I would say that all the globally-declared parameters should be prefixed
with _git to avoid namespace pollution, but really they shouldn't be in
the global space at all.
Index: Completion/Unix/Command/_git
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_git,v
retrieving revision 1.30
diff -u -r1.30 _git
--- Completion/Unix/Command/_git 29 Sep 2007 06:06:15 -0000 1.30
+++ Completion/Unix/Command/_git 30 Sep 2007 11:08:17 -0000
@@ -107,7 +107,7 @@
'(--no-tags -t --tags)'{-t,--tags}'[fetch remote tags]'
)
-
+local author_conversion_file_arg_spec
author_conversion_file_arg_spec='[specify author-conversion file]:author-conversion file:_files'
declare -g author_conversion_file_arg=
Messages sorted by:
Reverse Date,
Date,
Thread,
Author