Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: _git log arguments

X-seq: zsh-workers 23879
From: "Nikolai Weibull" <now@xxxxxxxx>
To: zsh-workers@xxxxxxxxxx
Subject: Re: PATCH: _git log arguments
Date: Mon, 1 Oct 2007 09:16:54 +0200
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=sh2uq8/K63opb2ijXa5PjWKiyispSGXP1dkIIlnZ+sA=; b=jwAerwqszrn3MsLUVuPfuN7i6uxdMxl2mS8MxlbFBR/mg/1Ug/QQrCVh5Fh6A4Xo9pVlFISp5r1cbdRDdXYo/sycG2l8U98qq3Fe+O/e55zQ1kPpSRx0xJJfXrAiPXDDlAagiRar6aFNpw9caCp9YnfSD0iXoj3KP41S+S53N+M=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=opNf5mKYvbkSyDJEw4QwsKaFnP1BsEta8F7LnI9/rR3Yv17tnlskdG5sdoRsHSlULTSdYlGxbQAs2f0GgdhvDVbFeOv37IictZUY7TonFYpCj0cnRawQctoqbbEyL9ZjTj4geLuvYPplDbICHP0xmoqP7SXHL44ZUu6tjuLpA5E=
In-reply-to: <20070930194014.GA18558@xxxxxxxxxxx>
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
References: <20070930194014.GA18558@xxxxxxxxxxx>
Sender: nikolai.weibull@xxxxxxxxx

On 9/30/07, Clint Adams <clint@xxxxxxx> wrote:
> I tried this with various things that called git-ls-files but
> they were insanely slow.

> -    $revision_arguments && ret=0
> +    "$revision_arguments[@]" \

Why use "$revision_arguments[@]"?  $revision_arguments works just as
good and you don't need all the quoting and expansion fluff.  I see
this style has been used for $merge_args as well, even though most of
the file doesn't.

> +    '*:tree-ish: _alternative c\:\:__git_committishs f\:\:_files' && ret=0

I don't like this at all.  Why not simply use __git_cached_files?  And
if we really need __git_committishs, let's at least use a separate
function for that with proper descriptions and tags.

Index: Completion/Unix/Command/_git
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_git,v
retrieving revision 1.33
diff -u -r1.33 _git
--- Completion/Unix/Command/_git        30 Sep 2007 18:18:18 -0000      1.33
+++ Completion/Unix/Command/_git        1 Oct 2007 07:15:31 -0000
@@ -1711,7 +1711,8 @@
   __git_setup_revision_arguments

   _arguments -S \
-    $revision_arguments && ret=0
+    $revision_arguments \
+    '*:file:__git_cached_files' && ret=0
 }

 # TODO: repository needs fixing

  nikolai

Follow-Ups:
- Re: PATCH: _git log arguments
  - From: Clint Adams

References:
- PATCH: _git log arguments
  - From: Clint Adams

Messages sorted by: Reverse Date, Date, Thread, Author