Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: _git and revision_arguments

X-seq: zsh-workers 23880
From: "Nikolai Weibull" <now@xxxxxxxx>
To: zsh-workers@xxxxxxxxxx
Subject: Re: PATCH: _git and revision_arguments
Date: Mon, 1 Oct 2007 09:21:45 +0200
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=k5DHs3f+hnLfijys/JnVtjgX7XP4MxtVc5VIIt+E9/8=; b=bCgrC2WqIo3qL3hkTvrW47pmxtb+5JQu/A8XJo2qPzFvFjAzca+aeoNEVoGhNU6AC85ljoxVDZj996n77nYy6reAz0VQkVHKKJ/I01EB+g6eZro0VhB7s9p8+KIj2r5Zgtb6a1z3utYz8L0nOaiy3FBTDEL8FMov5qWUfbDdjKk=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=R5dVYRgkZmIwgfCYdYVNTADn0OD9uerWlVeHUHA6tez/8e2hx09pTDZJZELD5MRUKjzrNY26uKVRHBP/354+QHR/Rsxq5xj/uMyZztDLGJ44RlPIIP5K3KOcvMMsttuDuqK9N1/ykxH3NVrNikGV5qLQytxsPnXaQYO1EJMcFbA=
In-reply-to: <20070930191803.GA16961@xxxxxxxxxxx>
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
References: <20070930191803.GA16961@xxxxxxxxxxx>
Sender: nikolai.weibull@xxxxxxxxx

On 9/30/07, Clint Adams <clint@xxxxxxx> wrote:
> This seems a slightly cleaner.

> +local -a revision_arguments

Ideally __git_setup_revision_arguments would take an argument that
told it what variable to use.  Making it harder to instigate such a
change doesn't make the code any cleaner.  Also, this change wastes
memory, as revision_arguments will always be in scope, while not
saving any (real) execution time.

  nikolai

References:
- PATCH: _git and revision_arguments
  - From: Clint Adams

Messages sorted by: Reverse Date, Date, Thread, Author