Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: uuid module out-of-tree



On Thu, Oct 11, 2007 at 10:44:28AM -0400, Clint Adams wrote:
> One thing to do would be to ship some kind of include file for autoconf
> so that the out-of-tree module can set all the necessary defines
> (such as HAVE_STDARG_H or HAVE_VARARGS_H) needed by system.h
> 
> Alternately, the portions of system.h that require config.h but don't
> need to be exported for out-of-tree modules could be split out to
> a different header or guarded with #ifdefs.

With the following aczshoot.m4 function (included from acinclude.m4)

AC_DEFUN(zsh_OOT,
[
AC_CHECK_HEADERS(stdarg.h varargs.h termios.h termio.h)

AC_TYPE_SIGNAL

AC_DEFINE([ZSH_OOT_MODULE], [], [Out-of-tree module])
])

and the following patch, the complete config.h is unnecessary.  The uuid
module doesn't need stdarg.h, varargs.h, termios.h, termio.h, or
RETSIGTYPE, however.  Any thoughts?

diff --git a/Src/system.h b/Src/system.h
index 781a907..022ace2 100644
--- a/Src/system.h
+++ b/Src/system.h
@@ -225,7 +225,7 @@ char *alloca _((size_t));
 #endif
 
 /* This is needed by some old SCO unices */
-#ifndef HAVE_STRUCT_TIMEZONE
+#if !defined(HAVE_STRUCT_TIMEZONE) && !defined(ZSH_OOT_MODULE)
 struct timezone {
     int tz_minuteswest;
     int tz_dsttime;



Messages sorted by: Reverse Date, Date, Thread, Author