Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: git-svn completion issue (patch)

X-seq: zsh-workers 23988
From: "Mikael Magnusson" <mikachu@xxxxxxxxx>
To: zsh-workers <zsh-workers@xxxxxxxxxx>
Subject: Re: git-svn completion issue (patch)
Date: Thu, 18 Oct 2007 21:53:57 +0200
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; bh=nhctQXywl6AUSABvWVHHL+2P9o4/gd/5nyUoDNPOjMk=; b=dw3y2+DVhTgg5DKhQjRbn2B2y0YTlBL+b5u7mcN+XcfPybjaP7xdOBEtVfUs/hvXBFH+al/C9o9OO+vgE4Qt/rDgXlI8erDOAISz/1p9kVDb06BsYRvdMzhOKoTvFyz8uCe+uCvjTU+TwRJ3ibb5wSIo96LqEqkl6Qg53kQXAKs=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=WLzNl96O5R0Giw88PUX36VaujuDB89t7GUYLHeXu3ZJ9TFOD9EAk9sJQypeYd87jwWU9grJIXoHD+F//AHpiKfkpVY2B3ShQxZPgDsH9bzSnnQBPofm/FU73GMuD6NOlp7iICom63R9MrfLYOhDLZPra/GmbTErUgoDf3orXR4s=
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm

On 16/10/2007, Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
> % git-svn <tab>
> ---- no match for: `command'
>
> I opened up _git to have a look, it seems it checks if $state is
> command, then declares an array $commands, which it then goes ahead
> and never uses for anything. I don't know exactly what incantation of
> _arguments or similar needs to be done here so no patch this time.

I think I figured it out, it at least seems to work correctly.

http://git.mikachu.ath.cx/?p=zsh-cvs.git;a=commitdiff_plain;h=gitsvn

--- a/Completion/Unix/Command/_git
+++ b/Completion/Unix/Command/_git
@@ -2345,6 +2345,7 @@ _git-svn () {
         'set-tree:commit given commit or tree to SVN repository'
         'show-ignore:output corresponding .gitignore file of svn:ignore'
         'commit-diff:commit diff of two tree-ishs')
+        _describe -t commands command commands && ret=0
       ;;
     (options)
       declare -a arguments


-- 
Mikael Magnusson

Follow-Ups:
- Re: git-svn completion issue (patch)
  - From: Clint Adams

Messages sorted by: Reverse Date, Date, Thread, Author