Re: Failures in today's build

[Clint Adams <clint@xxxxxxx>]

On Fri, Oct 19, 2007 at 04:02:14PM -0400, Vin Shelton wrote:
> With today's build I'm seeing the following failure on my linux boxes:
> 
> /opt/src/zsh-2007-10-19/Test/V01zmodload.ztst: starting.
> Segmentation fault (core dumped)
> 
> Apparently this is a result of a failed unloading of a module:
> 
> Running test: Unload the modules loaded by this test suite
> ZTST_test: expecting status: 0
> Input: /tmp/zsh.ztst.in.1099, output: /tmp/zsh.ztst.out.1099, error:
> /tmp/zsh.ztst.te
> rr.1099
> Segmentation fault (core dumped)
> make: [check] Error 139 (ignored)
> rm -rf Modules .zcompdump

If you don't zcurses -i after zmodloading, the hash is not
initialized. Here's a quick fix:

Index: Src/Modules/curses.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/curses.c,v
retrieving revision 1.12
diff -u -r1.12 curses.c
--- Src/Modules/curses.c	18 Oct 2007 20:44:13 -0000	1.12
+++ Src/Modules/curses.c	19 Oct 2007 20:18:26 -0000
@@ -58,7 +58,7 @@
 static struct ttyinfo saved_tty_state;
 static struct ttyinfo curses_tty_state;
 static LinkList zcurses_windows;
-static HashTable zcurses_colorpairs;
+static HashTable zcurses_colorpairs = NULL;
 
 #define ZCURSES_ERANGE 1
 #define ZCURSES_EDEFINED 2
@@ -599,7 +599,8 @@
 cleanup_(Module m)
 {
     freelinklist(zcurses_windows, (FreeFunc) zcurses_free_window);
-    deletehashtable(zcurses_colorpairs);
+    if (zcurses_colorpairs)
+	deletehashtable(zcurses_colorpairs);
     return setfeatureenables(m, &module_features, NULL);
 }