Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: * Re: Failed tests of zsh 4.3.5 in Solaris 10 w/Sun Studio 12 CC
- X-seq: zsh-workers 24607
 
- From: Oliver Kiddle <okiddle@xxxxxxxxxxx>
 
- To: Dagobert Michelsen <dam@xxxxxxxxxxxxx>, zsh-workers@xxxxxxxxxx
 
- Subject: Re: * Re: Failed tests of zsh 4.3.5 in Solaris 10 w/Sun Studio 12 CC
 
- Date: Tue, 26 Feb 2008 18:37:00 +0100
 
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws;  s=s1024; d=yahoo.co.uk;  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:Received:In-reply-to:From:References:To:Subject:Date:Message-ID;  b=4LZbggKwiYplFqEs0QL6UZXxyrzX0k29dVyeGGRtAUipO6eLd4F4gYIS38CmbOz1PLf/RGEXR46o/709jCvm+YIETSZB0GAP+KKgZcmjuBJDe6i1z5hoHzlr7oy6jUucc8b9IPgTZGfvxztWQw/yJoOmGXN7akwD8X7UZ7odPm0=  ;
 
- In-reply-to: <200802261610.m1QGAwJ3008939@xxxxxxxxxxxxxx> 
 
- Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
 
- References: <8AABEECB-A9A6-43EA-BED2-4BE376CBE349@xxxxxxxxxxxxx> <20080226141459.76dc362c@news01> <BD1EA7D6-C784-4ED9-9558-5B655CBC5096@xxxxxxxxxxxxx> <20080226145741.6e74fc22@news01> <656429B3-438B-4ECF-85C4-04E38D837D1A@xxxxxxxxxxxxx> <200802261610.m1QGAwJ3008939@xxxxxxxxxxxxxx>
 
Peter wrote:
> > Is this an error from zsh or is this a bug in libiconv?
It's actually better to avoid using libiconv and stick to the builtin
iconv on Solaris. It handles 646 correctly. I always make a point of
making sure it doesn't find GNU libiconv when compiling.
> +		    if (!codessetstr || !*codsetstr ||
> +			!strcmp(codesetstr, "646"))
> +			codesetstr == "US-ASCII";
Is the last line of this correct? Isn't it meant to be an assignment?
I would be inclined to wrap the whole thing inside #ifdef
_libiconv_version because the problem only occurs when using GNU iconv
instead of the Solaris builtin one.
Oliver
Messages sorted by:
Reverse Date,
Date,
Thread,
Author