Re: Bug#468386: zsh-beta: Slow command completion

[Clint Adams <clint@xxxxxxx>]

On Thu, Feb 28, 2008 at 05:54:28PM +0000, Peter Stephenson wrote:
> Limit the extra information for commands to people who *really* want it,
> by using another style ("extra_verbose") with an appropriate warning
> in the doc that this level of verbosity has speed implications.  The
> style is then reusable if this crops up elsewhere.

On Thu, Feb 28, 2008 at 09:54:14AM -0800, Bart Schaefer wrote:
> Or at least protect it with a style that is not generally set for any
> other purpose.

I went with a hyphen for consistency's sake.

Index: Completion/Unix/Type/_path_commands
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Type/_path_commands,v
retrieving revision 1.2
diff -u -r1.2 _path_commands
--- Completion/Unix/Type/_path_commands	19 Feb 2008 22:52:22 -0000	1.2
+++ Completion/Unix/Type/_path_commands	28 Feb 2008 18:22:14 -0000
@@ -26,7 +26,7 @@
 _path_commands() {
 local need_desc expl ret=1
 
-if zstyle -T ":completion:${curcontext}:" verbose; then
+if zstyle -T ":completion:${curcontext}:" extra-verbose; then
   local update_policy first
   if [[ $+_command_descriptions -eq 0 ]]; then
     first=yes
Index: Doc/Zsh/compsys.yo
===================================================================
RCS file: /cvsroot/zsh/zsh/Doc/Zsh/compsys.yo,v
retrieving revision 1.204
diff -u -r1.204 compsys.yo
--- Doc/Zsh/compsys.yo	23 Feb 2008 00:10:25 -0000	1.204
+++ Doc/Zsh/compsys.yo	28 Feb 2008 18:22:17 -0000
@@ -1672,6 +1672,12 @@
 tt(ignored-patterns) style, so they can be restored to consideration by
 the tt(_ignored) completer.
 )
+kindex(extra-verbose, completion style)
+item(tt(extra-verbose))(
+If set, the completion listing is more verbose at the cost of
+a probable decrease in completion speed.  Completion performance
+will suffer if this style is set to `true'.
+)
 kindex(ignored-patterns, completion style)
 item(tt(ignored-patterns))(
 A list of patterns; any trial completion matching one of the patterns