Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: _canonical_path not working on *BSD

X-seq: zsh-workers 24739
From: Baptiste Daroussin <baptiste.daroussin@xxxxxxxxx>
To: Peter Stephenson <pws@xxxxxxx>
Subject: Re: _canonical_path not working on *BSD
Date: Wed, 26 Mar 2008 16:27:10 +0100
Cc: zsh-workers@xxxxxxxxxx, Pea <zsh@xxxxxxxxxxxx>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:received:received:message-id:date:from:to:cc:subject:references:in-reply-to:mime-version:content-type:content-disposition:content-transfer-encoding:user-agent; bh=kt6kQD0m95qcdJY/nPIP1QXA79nTjDDfnvTjtSjlTFY=; b=WCrCC1RElkW6S+dHbSUtfyI24rX+zP6VoeSlJRwA0rUemVreEJvCtkU1Bcy5m0wJj4BjDmrIz3Y4yScwlZry258h/rKeUsHMPN0JJEPEkg4RHzOPmizHf4YVlvRvmnDaWFA9u3Y5PSc8eN853yLg6TQMRdiZJDnlw1LVpAn60y0=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=message-id:date:from:to:cc:subject:references:in-reply-to:mime-version:content-type:content-disposition:content-transfer-encoding:user-agent; b=H8Y6rwP7PvSK8GEl6B7JmNxXvWLI452ECFiGxiw62KI8e9Q2Q3zEHyZJSni+XiERqzjkfRJsvcfzT9NxNxoTY/m1cNsG5pw3hDBfzXmAnJyVvzD03HIwPC3r48Ohcl+SBhVBfcqF7+WBEwZjPCT6l8NEWg4vp9ychEqB3kD7ZAw=
In-reply-to: <20080326150552.52b3f1c4@news01>
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
References: <20080326114413.80713vrmznwpnyuc@xxxxxxxxxxxxxxx> <20080326150552.52b3f1c4@news01>


Quoting Peter Stephenson <pws@xxxxxxx>:


Pea suggested just removing the -q, but probably we should also redirect
stderr:

Index: Completion/Unix/Type/_canonical_paths
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Type/_canonical_paths,v
retrieving revision 1.1
diff -u -r1.1 _canonical_paths
--- Completion/Unix/Type/_canonical_paths	28 May 2006 18:36:06 -0000	1.1
+++ Completion/Unix/Type/_canonical_paths	26 Mar 2008 15:05:05 -0000
@@ -38,7 +38,8 @@
   files=($@)
 else
   for __index in $@; do
-    files+=$(readlink -qf $__index)
+    # BSD doesn't have -q, so redirect stderr.
+    files+=$(readlink -f $__index 2>/dev/null)
   done
 fi

@@ -48,7 +49,7 @@
   expref=${~origpref}
   [[ $origpref == (|*/). ]] && rltrim=.
   curpref=${${expref%$rltrim}:-./}
-  canpref=$(readlink -qf $curpref)
+  canpref=$(readlink -f $curpref 2>/dev/null)
   if [[ $? -eq 0 ]]; then
     [[ $curpref == */ && $canpref == *[^/] ]] && canpref+=/
     canpref+=$rltrim


--
Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


This only work on OpenBSD, readlink on FreeBSD doesn't allow -f.

here is the manpage on FreeBSD :http://www.freebsd.org/cgi/man.cgi?query=readlink&apropos=0&sektion=0&manpath=FreeBSD+6.3-RELEASE&format=htmlit seems to be ok on NetBSD, but I don't have tried (the manpage says-f is ok for readlink)

Darwin should have the same problem, the man page is the same as thefreebsd one :

http://developer.apple.com/documentation/Darwin/Reference/Manpages/man1/readlink.1.html

I will also see with the freebsd folks if it is not possible to add -fto readlink.


---
Baptiste

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

Follow-Ups:
- Re: _canonical_path not working on *BSD
  - From: Peter Stephenson

References:
- _canonical_path not working on *BSD
  - From: Baptiste Daroussin
- Re: _canonical_path not working on *BSD
  - From: Peter Stephenson

Messages sorted by: Reverse Date, Date, Thread, Author