Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: PATCH: isearch match highlighting
- X-seq: zsh-workers 24891
- From: Peter Stephenson <pws@xxxxxxx>
- To: zsh-workers@xxxxxxxxxx
- Subject: Re: PATCH: isearch match highlighting
- Date: Mon, 28 Apr 2008 12:02:59 +0100
- In-reply-to: <17393e3e0804280350h165f0466mb2776d9ff7ca03ae@xxxxxxxxxxxxxx>
- Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
- References: <godlygeek@xxxxxxxxx> <17393e3e0804261727s560acff7sb6125d8f8b46b4b4@xxxxxxxxxxxxxx> <200804271957.m3RJvxiS004075@xxxxxxxxxxxxxxxxxxx> <17393e3e0804271849l30fe20bdp4008fc8247298d12@xxxxxxxxxxxxxx> <20080428102001.7b55074e@news01> <17393e3e0804280350h165f0466mb2776d9ff7ca03ae@xxxxxxxxxxxxxx>
"Matt Wozniski" wrote:
> I think that the right fix is just unconditionally resetting skip_pos
> right before we conditionally set it.
Thanks, that looks fine and I even know basically why: I just added the
"nosearch" variable to optimise out a search when we're backtracking
since we know whether it succeeded or failed at the position in
question. That means skip_pos isn't handled quite the same way it used
to be, since it's in the optimised out code, and in particular it isn't
reset when we don't search (before it would have been even on a
failure). As you've reset it at exactly the point nosearch is set I
think that should cover everything.
--
Peter Stephenson <pws@xxxxxxx> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
Messages sorted by:
Reverse Date,
Date,
Thread,
Author