Re: PATCH: LFS

[Clint Adams <clint@xxxxxxx>]

On Sun, Jun 01, 2008 at 10:19:54AM -0700, Bart Schaefer wrote:
> I know I'm nit-picking here, but I think it would be better to reformat
> more of the paragraphs to avoid very long/very short lines, rather than
> concentrate on producing the smallest possible diff.
> 
> (Why was it even necessary to change "lfs" to "largefile" in the first
> place?  Force people to notice by deliberately breaking existing their
> existing config.status?)

What happened was that I discovered the hard way that the previous
largefile detection support would abort if CPPFLAGS was set but null.
Rather than protecting against this case by changing a + to a :+, it
struck me as much more robust to switch to autoconf's AC_SYS_LARGEFILE;
that way it will do the right thing if CPPFLAGS is set to the null
string, and even if it is set to arbitrary flags, and theoretically
do so on more platforms than previously.

We could hack --enable-lfs back in as some kind of alias to
--enable-largefile, but I suspect that it would be flimsy and dependent
on autoconf internals.

Another option is to make zsh_LARGE_FILE_SUPPORT behave exactly as
autoconf's AC_SYS_LARGEFILE except for s/largefile/lfs/ , but that
would deprive us of automatically receiving the benefits of any
upstream AC_SYS_LARGEFILE fixes or enhancements.

Better ideas?

Index: INSTALL
===================================================================
RCS file: /cvsroot/zsh/zsh/INSTALL,v
retrieving revision 1.35
diff -u -r1.35 INSTALL
--- INSTALL	1 Jun 2008 16:39:09 -0000	1.35
+++ INSTALL	1 Jun 2008 17:40:07 -0000
@@ -469,15 +469,16 @@
 ------------------------------------
 
 Some 32-bit systems allow special compilation modes to get around the 2GB
-file size barrier.  This is enabled by default; use --disable-largefile to turn
-it off.  Not all systems recognize the test used by zsh (via the getconf
-command), so flags may need to be set by hand.  On HP-UX 10.20, zsh has
-been successfully compiled with large file support by configuring with
+file size barrier.  This is enabled by default; use --disable-largefile
+to turn it off.  Not all systems recognize the test used by zsh (via the
+getconf command), so flags may need to be set by hand.  On HP-UX 10.20,
+zsh has been successfully compiled with large file support by configuring
+with
   CC="cc -Ae" CPPFLAGS="-D_LARGEFILE_SOURCE -D_FILE64" configure \
   --enable-largefile ...
 
-Furthermore, use of --enable-largefile will also enable 64-bit arithmetic for
-shell parameters, and anywhere they are used such as in mathematical
+Furthermore, use of --enable-largefile will also enable 64-bit arithmetic
+for shell parameters, and anywhere they are used such as in mathematical
 formulae.  This depends only on the shell finding a suitable 64-bit integer
 type; it does not require that support for large files is actually
 enabled.  Hence --enable-largefile is useful on many 32-bit systems
Index: Src/zsh.h
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/zsh.h,v
retrieving revision 1.135
diff -u -r1.135 zsh.h
--- Src/zsh.h	1 Jun 2008 16:39:10 -0000	1.135
+++ Src/zsh.h	1 Jun 2008 17:40:21 -0000
@@ -34,9 +34,8 @@
  * Our longest integer type:  will be a 64 bit either if long already is,
  * or if we found some alternative such as long long.
  * Currently we only define this to be longer than a long if
- * --enable-largefile
- * was given.  That enables internal use of 64-bit types even if
- * no actual large file support is present.
+ * --enable-largefile * was given.  That enables internal use of 64-bit
+ * types even if no actual large file support is present.
  */
 #ifdef ZSH_64_BIT_TYPE
 typedef ZSH_64_BIT_TYPE zlong;