Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: Fix a typo in _git.

X-seq: zsh-workers 25473
From: "Mikael Magnusson" <mikachu@xxxxxxxxx>
To: zsh-workers <zsh-workers@xxxxxxxxxx>
Subject: Re: Fix a typo in _git.
Date: Mon, 18 Aug 2008 01:30:13 +0200
Cc: "Clint Adams" <clint@xxxxxxx>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=qNTUqqHkhzuMkuat8VnW95JYuJBaW1PF+AVjxyTm0fA=; b=aBQkk672ZUcxNVeb5S4W67KZNHaqQizB0yMZ5o7qm3eEdcYJDvv9DqD5xDDcwnIb5e 0H3/XUwkl8oAeuaxOfHC9/qyNyRMmxyUgoQQsQQ3Jz6rDEFPhG/ZQAn0NeTkD3dY4jSr fVOV2vxGVqGpgnFPRcvHeTsq49auE1Il0OOg8=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=t5QUUp3w3h14GoFpu5rJSw3BHD67dJxrmLVo0Np0p7ww1pGccOgUsJ6nVJAxOkLuRW Yz3q0C3R0TQ2GAp5NZPoIwphV83A3NQEAAjpnIyXuhyDSHkhYDnLQX4D2cYzbsaxzdkY CxPKy+coX3xkdd1UA64RKdETsWauniap6C25M=
In-reply-to: <237967ef0808171623rcedc156jc9c191af34862b8d@xxxxxxxxxxxxxx>
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
References: <237967ef0808151656j7787f169g4b3456910e05bfc2@xxxxxxxxxxxxxx> <237967ef0808171623rcedc156jc9c191af34862b8d@xxxxxxxxxxxxxx>

Apparently sometimes fixing typos breaks more than it fixes :). Sorry
about gmail line-wrapping too...
Here's the direct link to the patch since i can't make gmail not suck.
http://git.mika.l3ib.org/?p=zsh-cvs.git;a=commitdiff_plain;h=362b127e23341ab17988ef6ef2bf45dece5cbe8e

commit 362b127e23341ab17988ef6ef2bf45dece5cbe8e
Author: Mikael Magnusson <mikachu@xxxxxxxxx>
Date:   Mon Aug 18 01:21:04 2008 +0200

    _git: Fix a typo that looks like it should break more than it does.

diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
index 52c2b41..047e666 100644
--- a/Completion/Unix/Command/_git
+++ b/Completion/Unix/Command/_git
@@ -2573,7 +2573,8 @@ _git-svn () {
           arguments+=('--stdin[read list of commits to commit from stdin]')
           ;;
         (show-ignore)
-          arguments+=('-r
--revision)'{-r,--revision)'[undocumented]:revision:->__git_svn_revisions'
+          arguments+=('-r
--revision)'{-r,--revision}'[undocumented]:revision:->__git_svn_revisions')
+          ;;
         (dcommit)
           arguments+=(
             '(-n --dry-run)'{-n,--dry-run}'[output git-commands that
would show diffs that would be committed]')


2008/8/18 Mikael Magnusson <mikachu@xxxxxxxxx>:
> % in vim just found this for me.
>
> commit 67345b5a05c7660933a73c7a458704c6df4b7411
> Author: Mikael Magnusson <mikachu@xxxxxxxxx>
> Date:   Mon Aug 18 01:21:04 2008 +0200
>
>    _git: Fix a typo that looks like it should break more than it does.
>
> diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
> index 52c2b41..0345f7e 100644
> --- a/Completion/Unix/Command/_git
> +++ b/Completion/Unix/Command/_git
> @@ -2573,7 +2573,7 @@ _git-svn () {
>           arguments+=('--stdin[read list of commits to commit from stdin]')
>           ;;
>         (show-ignore)
> -          arguments+=('-r
> --revision)'{-r,--revision)'[undocumented]:revision:->__git_svn_revisions'
> +          arguments+=('-r
> --revision)'{-r,--revision}'[undocumented]:revision:->__git_svn_revisions'
>         (dcommit)
>           arguments+=(
>             '(-n --dry-run)'{-n,--dry-run}'[output git-commands that
> would show diffs that would be committed]')
>
>
> --
> Mikael Magnusson
>



-- 
Mikael Magnusson

Follow-Ups:
- Re: Fix a typo in _git.
  - From: Phil Pennock

References:
- Fix a typo in _git.
  - From: Mikael Magnusson
- Re: Fix a typo in _git.
  - From: Mikael Magnusson

Messages sorted by: Reverse Date, Date, Thread, Author