Re: [PATCH] Completion for chrt and ionice

[Jörg Sommer <joerg@xxxxxxxxxxxx>]

Hallo,

Jörg Sommer <joerg@xxxxxxxxxxxx> wrote:
> commit e2da3b57bfa4145811aa3b3921edb329b7bef1f7
> Author: Jörg Sommer <joerg@xxxxxxxxxxxx>
> Date:   Mon Sep 22 16:54:28 2008 +0200
>
>     The pid for -p must follow the option
>     
>     The process ID is the mandatory argument of the -p option.
>
> diff --git a/Completion/Linux/Command/_ionice b/Completion/Linux/Command/_ionice
> index fd49dcd..b7cd21b 100644
> --- a/Completion/Linux/Command/_ionice
> +++ b/Completion/Linux/Command/_ionice
> @@ -1,23 +1,12 @@
>  #compdef ionice
>  
> -local context state line
> -typeset -A opt_args
> -
>  _arguments \
>    '(* -)-h[display usage information]' \
> -  '-p[interpret args as process ID]' \
> +  '(*)-p[interpret args as process ID]:pid:_pids' \
                                         ^^^^^^^^^^
Why this is missing in 25717?

>    '-c[scheduling class]:class:(( 1\:realtime 2\:best-effort 3\:idle ))' \
>    '-n[scheduling class priority]:class-pririty:((
>      0\:high\ priority
>      {6..1}\:
>      7\:low\ priority
>    ))' \
> -  '*::command or pid:->cmd_or_prio' \
> -  && return 0
> -
> -if (( $+opt_args[-p] ))
> -then
> -    _pids
> -else
> -    _normal
> -fi
> +  '*::command:_normal'

Bye, Jörg.
-- 
Computer Science is no more about Computers than astronomy is about
telescopes.
            (Edsger Wybe Dijkstra)