Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: Multibyte test regressed on MacOSX Leopard



On Sat, Oct 18, 2008 at 18:13, Peter Stephenson
<p.w.stephenson@xxxxxxxxxxxx> wrote:
> ..On Wed, 15 Oct 2008 21:55:56 +0300
> "Äsmail DÃnmez" <ismail@xxxxxxxxxxx> wrote:
>> With the latest changes, multibyte test now fails on MacOSX 10.5.5 Leopard,
>>
>> ./D07multibyte.ztst: starting.
>> Testing multibyte with locale en_US.UTF-8
>> Test ./D07multibyte.ztst failed: bad status 1, expected 0 from:
>>  mkdir glob
>>  mkdir glob/'()Ä' glob/'()Ä'
>>  mkdir glob/'()Ä'/foo glob/'()Ä'/bar
>>  tmp1=('glob/\(\)Ä/*')
>>  print $~tmp1
>>  tmp1=('glob/\(\)Ä/*')
>>  print $~tmp1
>> Error output:
>> (eval):5: no matches found: glob/\(\)Ä/*
>> Was testing: Backslashes and metafied characters in patterns
>> ./D07multibyte.ztst: test failed.
>
> I wonder if this is because the characters are stored in a different
> format in file names.
>
> Index: Test/D07multibyte.ztst
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Test/D07multibyte.ztst,v
> retrieving revision 1.26
> diff -u -r1.26 D07multibyte.ztst
> --- Test/D07multibyte.ztst      11 Oct 2008 22:16:01 -0000      1.26
> +++ Test/D07multibyte.ztst      18 Oct 2008 15:12:56 -0000
> @@ -396,13 +396,10 @@
>  >OK
>  >OK
>
> -  mkdir glob
> -  mkdir glob/'()Ä' glob/'()Ä'
> -  mkdir glob/'()Ä'/foo glob/'()Ä'/bar
> -  tmp1=('glob/\(\)Ä/*')
> -  print $~tmp1
> -  tmp1=('glob/\(\)Ä/*')
> -  print $~tmp1
> +  tmp1='glob/\(\)Ä/*'
> +  [[ glob/'()Ä'/foo == $~tmp1 ]] && print "Matched against $tmp1"
> +  tmp1='glob/\(\)Ä/*'
> +  [[ glob/'()Ä'/bar == $~tmp1 ]] && print "Matched against $tmp1"
>  0:Backslashes and metafied characters in patterns
> ->glob/()Ä/foo
> ->glob/()Ä/bar
> +>Matched against glob/()Ä/*
> +>Matched against glob/()Ä/*

This fixed the problem for me.

Thanks!

/ismail


Messages sorted by: Reverse Date, Date, Thread, Author