Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: add zle-line-finish special widget

X-seq: zsh-workers 26343
From: Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>
To: zsh-workers@xxxxxxxxxx
Subject: Re: PATCH: add zle-line-finish special widget
Date: Sat, 17 Jan 2009 17:48:08 +0000
In-reply-to: <m33afix0x0.fsf_-_@xxxxxxxxxxxxxx>
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
References: <18789.30656.261463.382208@xxxxxxxxxxxxxxxxxx> <20090110095231.GA61601@xxxxxxxxxxxxxxxxxxxx> <m33afq97gg.fsf@xxxxxxxxxxxxxx> <20090111025418.GA7272@xxxxxxxxxxxxxxxxxxxx> <m3tz857mkm.fsf@xxxxxxxxxxxxxx> <090111110748.ZM12349@xxxxxxxxxxxxxxxxxxxxxx> <m3r63975pd.fsf@xxxxxxxxxxxxxx> <m3ocyd70aj.fsf@xxxxxxxxxxxxxx> <090111193317.ZM12655@xxxxxxxxxxxxxxxxxxxxxx> <m3k5916unp.fsf@xxxxxxxxxxxxxx> <m33afix0x0.fsf_-_@xxxxxxxxxxxxxx>

On Fri, 16 Jan 2009 18:54:03 -0500
Greg Klanderman <gak@xxxxxxxxxxxxxx> wrote:
> > it's possible that the zle-line-finish widget should not run when
> > errflag != 0.
> 
> > I don't know all the ramifications of the values of various globals
> > at the end of zlecore().  PWS?

I suspect if you don't set errflag to 0 at that point (and it's
non-zero) it might not run anyway, but I haven't looked (I would have to
trace the code or test it, which you can do if you feel inclined).
I don't know if this is correct or not---it really depends what
zle-line-finish is designed to do.  If it's a catch-all tidy up, it
probably *should* run and then you probably should set errflag to 0
after saving the surrounding value.

You might want to check if Bart's recent comments on zle-line-init are
relevant.

-- 
Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/

References:
- Re: some way to inherit kill ring in su'd shell?
  - From: Greg Klanderman
- PATCH: add zle-line-finish special widget
  - From: Greg Klanderman

Messages sorted by: Reverse Date, Date, Thread, Author