Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] don't call regfree() on uninitialized regex_t

X-seq: zsh-workers 26370
From: Phil Pennock <zsh-workers+phil.pennock@xxxxxxxxxxxx>
To: Wayne Davison <wayned@xxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] don't call regfree() on uninitialized regex_t
Date: Mon, 19 Jan 2009 13:35:26 -0800
Cc: zsh-workers@xxxxxxxxxx
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=d200807; d=spodhuis.org; h=Received:Date:From:To:Cc:Subject:Message-ID:Mail-Followup-To:References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; b=KoYXX+bS5KwQcBAnBI/lSqajO3Yvyp4wd/pufmNsi5ufNndf2WGfXDA9MVbvsdi4WXXT2mVgZDB0eMEEKPwtHKQvCdAmNosGDgfyVF4JOxN19u4LYMAij94xaH+8XS7qsNWo3TOkHCGsZATDeeOqGESQDhxh/YT9UtHA+1L6D/U=;
In-reply-to: <20090119082203.GA16606@xxxxxxxxx>
Mail-followup-to: Wayne Davison <wayned@xxxxxxxxxxxxxxxxxxxxx>, zsh-workers@xxxxxxxxxx
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
References: <20090119082203.GA16606@xxxxxxxxx>

On 2009-01-19 at 00:22 -0800, Wayne Davison wrote:
> While I was fixing a few compiler warnings in zcond_regex_match(), I
> noticed that regfree() could be called on an uninitialized regex_t if
> the "id" value passed in to the function was invalid.  Attached is one
> possible fix.

Thanks -- looks like I was too clever for my own good.

-Phil

References:
- [PATCH] don't call regfree() on uninitialized regex_t
  - From: Wayne Davison

Messages sorted by: Reverse Date, Date, Thread, Author