Re: Modules/attr.c compile error on Mac OS X

[Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>]

Bart Schaefer wrote:
> However, it didn't build the attr module.  Still didn't build it after
> a "make clee an".  Missing dependency?  Trying again from "make distclean":
> OK, compiled the attr module that time.

I think that's because config.modules.sh doesn't get rerun
automatically.  I've come across the same thing.  config.modules should
probably depend on it somewhere.  I wonder if the following fixes it or
simply introduces some dependency loop...  It's odd that *nothing*
currently depends on config.modules, but maybe I just screwed up.

> I tried this:
>...
> Is there more that should be tested?

Looks pretty good to me; suggests that with the extra arguments it's not
fundamentally broken.

We could probably do with a Test module that only runs if zsh/attr is
loadable and the file system supports extended attributes (i.e. if it
doesn't load it should report as "couldn't test" rather than "test
failed").

Index: Makefile.in
===================================================================
RCS file: /cvsroot/zsh/zsh/Makefile.in,v
retrieving revision 1.19
diff -u -r1.19 Makefile.in
--- Makefile.in	1 Feb 2008 11:31:36 -0000	1.19
+++ Makefile.in	8 Mar 2009 21:45:59 -0000
@@ -41,7 +41,7 @@
 # ========== DEPENDENCIES FOR BUILDING ==========
 
 # default target
-all: config.h
+all: config.h config.modules
 	@for subdir in Src Doc; do \
 	  (cd $$subdir && $(MAKE) $(MAKEDEFS) $@) || exit 1; \
 	done
@@ -142,8 +142,9 @@
 stamp-h: $(sdir)/config.h.in config.status
 	cd $(dir_top) && $(SHELL) ./config.status config.h $@
 
-config.modules: $(sdir)/config.h.in config.status
-	cd $(dir_top) && $(SHELL) ./config.status $@
+config.modules: $(sdir)/config.h.in config.status config.modules.sh
+	cd $(dir_top) && $(SHELL) ./config.status $@ && \
+	$(SHELL) ./config.modules.sh
 
 $(sdir)/config.h.in: $(sdir)/stamp-h.in
 $(sdir)/stamp-h.in: $(sdir)/configure.ac \

-- 
Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/