Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: PATCH: silence compiler
- X-seq: zsh-workers 27363
- From: Stephane Chazelas <stephane_chazelas@xxxxxxxx>
- To: Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>
- Subject: Re: PATCH: silence compiler
- Date: Sat, 7 Nov 2009 19:42:33 +0000
- Cc: Zsh hackers list <zsh-workers@xxxxxxx>
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.fr; h=Received:X-Yahoo-SMTP:X-YMail-OSG:X-Yahoo-Newman-Property:Date:From:To:Cc:Subject:Message-ID:Mail-Followup-To:References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To:User-Agent; b=OkS8SuApU/kTm7K0CBb5q7LqKC5mhxHHGkFEVlFXn3SrftX6YdkzO+WqFGqsVichOAJGUTveGq50DB89EwigXotjx3rtHV8VknpM3kxLyxmOEQMSgnZeRa27IzjmkItkbJwIa/8zovAkEX45Gu74oNgB9qnoOv7pv8YrxTl3q/Y= ;
- In-reply-to: <3378.1257542338@pws-pc>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mail-followup-to: Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>, Zsh hackers list <zsh-workers@xxxxxxx>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <3378.1257542338@pws-pc>
2009-11-06 21:18:58 +0000, Peter Stephenson:
> Index: Src/Modules/attr.c
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Src/Modules/attr.c,v
> retrieving revision 1.5
> diff -u -r1.5 attr.c
> --- Src/Modules/attr.c 5 Nov 2009 09:44:32 -0000 1.5
> +++ Src/Modules/attr.c 6 Nov 2009 21:18:29 -0000
> @@ -42,7 +42,7 @@
> switch (symlink) {
> case 0:
> return getxattr(path, name, value, size);
> - case 1:
> + default:
> return lgetxattr(path, name, value, size);
> }
[...]
I don't know the context but why not if/else? or return (symlink
? lgetxattr... : getxattr... )?
Cheers,
Stephane
Messages sorted by:
Reverse Date,
Date,
Thread,
Author