Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: silence compiler



2009-11-06 21:18:58 +0000, Peter Stephenson:
> Index: Src/Modules/attr.c
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Src/Modules/attr.c,v
> retrieving revision 1.5
> diff -u -r1.5 attr.c
> --- Src/Modules/attr.c	5 Nov 2009 09:44:32 -0000	1.5
> +++ Src/Modules/attr.c	6 Nov 2009 21:18:29 -0000
> @@ -42,7 +42,7 @@
>      switch (symlink) {
>      case 0:
>          return getxattr(path, name, value, size);
> -    case 1:
> +    default:
>          return lgetxattr(path, name, value, size);
>      }
[...]

I don't know the context but why not if/else? or return (symlink
? lgetxattr... : getxattr... )?

Cheers,
Stephane



Messages sorted by: Reverse Date, Date, Thread, Author