Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: Improving some return-value checking
- X-seq: zsh-workers 27528
- From: Wayne Davison <wayned@xxxxxxxxxxxxxxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: Re: Improving some return-value checking
- Date: Wed, 16 Dec 2009 10:53:18 -0800
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to :content-type; bh=SKYBsBzei6cCf4h01TsOAl7ym3OfeIXyH/XPn3XT8Ls=; b=Lt4Uny+nM03QBoPEV6fFExZOMpJDZWPNZJ2pFjl12ovpqliZ9wB3hHldSgQ/ZERPl5 AbQDHe08P6pvFkwMjmsATBwTVaf/MigqO73LIOE+Ky643fai0DqTOLuWaJUOnufh0tFs cw+kDsuAadk0GX7wDoe0eQ+emgor13a2gKUFU=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; b=t3Sr4iAY9z6CPMXEsqTsq1s6LP7ewGyhd+HavpTncSouO7nrWm5cyL4oJLioceGmod 3ACUUvmeULaYS8Mo8a4u6bhXmAiANt1BpZm+v6a5kFQVzWvF+gevLSgWv2UGPPpbzYPO 0qxP0x22wLNd4NFlcbJuPUHZu5I4hj3dG7EQY=
- In-reply-to: <20090315005826.GC18440@xxxxxxxxx>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20090315005826.GC18440@xxxxxxxxx>
- Sender: 4wayned@xxxxxxxxx
On Sat, Mar 14, 2009 at 4:58 PM, Wayne Davison <wayned@xxxxxxxxxxxxxxxxxxxxx
> wrote:
> The second is specific to checking the return value of pipe() [...]
> I haven't yet patched the various read()/write()/fwrite() calls
> that are not checking their return values
>
I finally got back to this, and checked in some cleanup for both the pipe()
calls and the read()/write() calls that were causing compiler warnings.
This gets rid of all the "ignoring return value" compiler warnings, and
should make some of the read/write calls slightly safer (since they now
handle EINTR). There is one remaining FIXME (in exec.c) where I didn't
error-handle an mpipe() call. Since it wasn't error-handled before, it will
be fine for now, but we may want to figure out how to do an error exit from
that point.
..wayne..
Messages sorted by:
Reverse Date,
Date,
Thread,
Author