Re: Quoting problems with _zip (unzip) completer

[Peter Stephenson <pws@xxxxxxx>]

"Benjamin R. Haskell" wrote:
> Yes.  That works for me for the Zsh pattern problem.  Still exploring 
> the zipinfo problem.

Good; I didn't look at the latter, it sounded less like it needed low
level hackery.

There's definitely room in the market for someone to write a zsh
completion function how-to, even on top of the documentation, the
existing functions, and From Bash to Z-Shell.  The use of quoted
strings direct from the command line vs. unquoted strings directly
representing file names could do with some description.

> > Index: Completion/Unix/Command/_zip
> > +      if [[ $zipfile !=  $_zip_cache_list ]]; then
> > +        _zip_cache_name="$zipfile"
> 
> Shouldn't the first line there be $_zip_cache_list be $_zip_cache_name?  
> (The problem was there before your patch [line 119 prepatch, 128 post])  
> Otherwise I don't think it'll ever cache the list.

Yes, I'll tweak that in case this change ever gets submitted.

-- 
Peter Stephenson <pws@xxxxxxx>            Software Engineer
Tel: +44 (0)1223 692070                   Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom