Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: vcs_info: Ignore chpwd_functions[] in VCS_INFO_realpath()

X-seq: zsh-workers 27767
From: Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx>
To: Mikael Magnusson <mikachu@xxxxxxxxx>
Subject: Re: PATCH: vcs_info: Ignore chpwd_functions[] in VCS_INFO_realpath()
Date: Wed, 03 Mar 2010 22:24:12 +0100
Cc: zsh-workers@xxxxxxx, Bart Trojanowski <bart@xxxxxxxxx>
In-reply-to: <237967ef1003031317u4f24adcehe9396423c8ecfcd2@xxxxxxxxxxxxxx> (Mikael Magnusson's message of "Wed, 3 Mar 2010 22:17:17 +0100")
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
References: <1267650366-11200-1-git-send-email-ft@xxxxxxxxxxxxxxxxxxx> <237967ef1003031317u4f24adcehe9396423c8ecfcd2@xxxxxxxxxxxxxx>

Mikael Magnusson wrote:
> On 3 March 2010 22:06, Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx> wrote:
[...]
>>  (
>>     (( ${+functions[chpwd]} )) && unfunction chpwd
>> +    (( ${#chpwd_functions} )) && chpwd_functions=()
>>     setopt chaselinks
>>     builtin cd $1 2>/dev/null && pwd
>>  )
>
> Why not just use cd -q?

Good point. `-q' wasn't there when I started vcs_info. :-)

It's the better solution though. I'll send a patch in a minute.

Regards, Frank

-- 
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
                                                  -- RFC 1925

References:
- PATCH: vcs_info: Ignore chpwd_functions[] in VCS_INFO_realpath()
  - From: Frank Terbeck
- Re: PATCH: vcs_info: Ignore chpwd_functions[] in VCS_INFO_realpath()
  - From: Mikael Magnusson

Messages sorted by: Reverse Date, Date, Thread, Author