Re: [PATCH] Quote components before using it is pattern

[Mikael Magnusson <mikachu@xxxxxxxxx>]

On 21 August 2010 18:54, Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> On Aug 21,  2:46pm, Mikael Magnusson wrote:
> } Subject: Re: [PATCH] Quote components before using it is pattern
> }
> } On 14 October 2008 17:01, Jorg Sommer <joerg@xxxxxxxxxxxx> wrote:
>
> Wow, digging back into history a bit here ...

Not that much digging involved, git log **/_multi_parts showed this
was the latest change, I tried undoing and it 'worked'. :)

> } >> A component might contain a character active in patterns, like * or ().
> } >>
> } >> The characters in the temporary variable tmp1 must be quote, before the
> } >> pattern is build with them.
> }
> } This patch sort of breaks completing when the first segment has spaces
> } for me.
>
> As has come up elsewhere, the problem is that ${(q)...} is a bit too
> aggressive for the purpose to which it is being put.  We need to quote
> pattern characters in tmp1, but not other characters like spaces.
>
> There's a rather ugly hunk of code in _path_files that does something
> like this (see the comment "Explanation of substitution: ...") but
> unfortunately I don't have time this morning to try to adapt it for
> _multi_parts.

I merrily thought "Oh, I'll take a look at it then", but of course I
almost immediately exploded. I might try poking at it a bit later,
when I've gathered all my pieces.

-- 
Mikael Magnusson