Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] _git: Don't cause errors if git isn't installed

X-seq: zsh-workers 28222
From: Simon Ruderich <simon@xxxxxxxxxxxx>
To: zsh-workers@xxxxxxx
Subject: Re: [PATCH] _git: Don't cause errors if git isn't installed
Date: Wed, 1 Sep 2010 20:43:45 +0200
In-reply-to: <1281464025-24258-1-git-send-email-zsh@xxxxxxxxxx>
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
References: <1281464025-24258-1-git-send-email-zsh@xxxxxxxxxx>

On Tue, Aug 10, 2010 at 02:13:45PM -0400, Benjamin R. Haskell wrote:
> Setting up a new system under Cygwin on Windows 7, one of the first
> things I tried (out of habit) was git<space><Tab>.  I'm not sure this is
> the 'right' way to patch it, but other not-installed commands didn't
> seem to cause the same kinds of errors:
>
> $ screen <Tab># no extra output
> $ php <Tab># no extra output
> $ git <Tab>(eval):1: command not found: git
> (eval):1: command not found: git
>
> By "not the 'right' way", I just mean that this version accomplishes the goal
> of eliminating the error messages, but maybe a more-correct solution would be
> to replace some/all of the $(git...)-style calls with $(_call_program [tag]
> git...)?
>
> Best,
> Ben

Hi all,

Could somebody please review this patch.

I'm not sure myself if this is "the right way", but I think the
problem should get fixed.

Simon
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9

Attachment: pgp4ymdrnL1aM.pgp
Description: PGP signature

References:
- [PATCH] _git: Don't cause errors if git isn't installed
  - From: Benjamin R. Haskell

Messages sorted by: Reverse Date, Date, Thread, Author