PROMPT_SP and empty PROMPT_EOL_MARK

[Mikael Magnusson <mikachu@xxxxxxxxx>]

The recent patches to PROMPT_SP broke my local hacks that removed the
ugly % sign, so I found out about PROMPT_EOL_MARK but why on earth
does it

              If not set or empty, the default  behavior
              is equivalent to the value `%B%S%#%s%b'.

What is the rationale for disallowing an empty indicator? If someone
wants the default they can just unset the parameter.

diff --git a/Src/utils.c b/Src/utils.c
index 8e557fd..8a2db5e 100644
--- a/Src/utils.c
+++ b/Src/utils.c
@@ -1285,7 +1285,7 @@ preprompt(void)
        char *eolmark = getsparam("PROMPT_EOL_MARK");
        char *str;
        int percents = opts[PROMPTPERCENT], w = 0;
-       if (!eolmark || !*eolmark)
+       if (!eolmark)
            eolmark = "%B%S%#%s%b";
        opts[PROMPTPERCENT] = 1;
        str = promptexpand(eolmark, 1, NULL, NULL, NULL);
diff --git a/Doc/Zsh/params.yo b/Doc/Zsh/params.yo
index 5d85f58..bec0027 100644
--- a/Doc/Zsh/params.yo
+++ b/Doc/Zsh/params.yo
@@ -1158,7 +1158,7 @@ item(tt(PROMPT_EOL_MARK))(
 When the tt(PROMPT_CR) and tt(PROMPT_SP) options are set, the
 tt(PROMPT_EOL_MARK) parameter can be used to customize how the end of
 partial lines are shown.  This parameter undergoes prompt expansion, with
-the tt(PROMPT_PERCENT) option set.  If not set or empty, the default
+the tt(PROMPT_PERCENT) option set.  If not set, the default
 behavior is equivalent to the value `tt(%B%S%#%s%b)'.
 )
 vindex(PS1)


-- 
Mikael Magnusson