Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

[PATCH] Correct isident false positive.

X-seq: zsh-workers 28630
From: Ricky Zhou <ricky@xxxxxxxxx>
To: zsh-workers@xxxxxxx
Subject: [PATCH] Correct isident false positive.
Date: Sun, 16 Jan 2011 07:05:20 -0500
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
Mail-followup-to: zsh-workers@xxxxxxx
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm

I'm not familiar with with the precise definition of an identifier, so
somebody might want to double-check that this change (which assumes that
valid identifiers cannot start with a '[') is correct.  This fixes the
following crash:

printf %n '[0]'

---
 Src/params.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/Src/params.c b/Src/params.c
index 8510b92..ba6cd63 100644
--- a/Src/params.c
+++ b/Src/params.c
@@ -1009,6 +1009,8 @@ isident(char *s)
      * definitely not a valid identifier.         */
     if (!*ss)
 	return 1;
+    if (s == ss)
+	return 0;
     if (*ss != '[')
 	return 0;
 
-- 
1.7.3.4

Attachment: pgpWQ7gvX6aNM.pgp
Description: PGP signature

Follow-Ups:
- Re: [PATCH] Correct isident false positive.
  - From: Peter Stephenson

Messages sorted by: Reverse Date, Date, Thread, Author