Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: lhw@xxxxxxxx, 611175@xxxxxxxxxxxxxxx
- X-seq: zsh-workers 28740
- From: Phil Pennock <zsh-workers+phil.pennock@xxxxxxxxxxxx>
- To: Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx>
- Subject: Re: lhw@xxxxxxxx, 611175@xxxxxxxxxxxxxxx
- Date: Fri, 11 Feb 2011 01:43:25 -0500
- Cc: zsh-workers@xxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=spodhuis.org; s=d200912; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=/qoSY3EAeX0IKPVK16Eio9fhZ9rzFwPONguLoIU7xAc=; b=CdjNCyg2XfnftneLx4BnZQPAOo1QcjBVDMhGC2Xfts9SAnhwUeslwbxPVB/mlhgaj2bmBgoD7liC4rGtcRxFxkpHDqP0wjRx3nhjxZ/2i4/i8ME9FMMizSDy2e/1m1ONr+NCauonXenkSXnqDP5ozR09JxX3pfcRQXrqpMMg0Eo=;
- In-reply-to: <877hd7gjuf.fsf@ft.bewatermyfriend.org>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mail-followup-to: Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx>, zsh-workers@xxxxxxx
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <877hd7gjuf.fsf@ft.bewatermyfriend.org>
On 2011-02-11 at 07:34 +0100, Frank Terbeck wrote:
> ...now that CVS is back...
>
> Here's a fix for an issue with vcs_info's subversion detection, which
> was reported in the debian BTS (issue #611175¹).
That entry complains that .svn/ on its own is not sufficient and a more
thorough check is needed.
Your patch adds dead code, because if .svn already exists as a
directory, the function will have returned true already.
I suspect that you should be *replacing* the [[ -d ".svn" ]] check.
-Phil
Messages sorted by:
Reverse Date,
Date,
Thread,
Author