Re: [PATCH 3/4] Fix git-branch -[dD] -r completion

[Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx>]

Benjamin R. Haskell wrote:
> On Fri, 18 Mar 2011, Frank Terbeck wrote:
>
>> Hm, with this patch, this:
>>
>> % git branch -d -r <tab>
>>
>> works. But this:
>>
>> % git -r -d <tab>
>>
>> doesn't.
>
> Without 'branch'?

Sorry typo. It doesn't work *with* branch.

>> I suppose, that's not intentional?
>
> With the 'branch' there, both:
>
> (i) git branch -d -r <tab>
> and
> (ii) git branch -r -d <tab>
>
> seem to behave identically whether or not this patch is applied.  With
> or without the patch (i) seems fine AFAICT.  But (ii) doesn't seem to
> complete branches, even though I think it should.

They don't for me.

% git branch -d -r <tab>
- remote branch name -
origin/debian           origin/upstream       
origin/HEAD             origin/upstream-import
origin/master           zsh.git/master

And:

% git branch -r -d <tab>

results in

% git branch -r -d -

If I tab again, I get:

% git branch -r -d -<tab>
- option -
--abbrev         -- set minimum SHA1 display-length                                                                                                                 
--color          -- turn on branch coloring                                                                                                                         
--no-abbrev      -- do not abbreviate sha1s                                                                                                                         
--no-color       -- turn off branch coloring                                                                                                                        
-r               -- delete remote-tracking branches                                                                                                                 
--verbose    -v  -- show SHA1 and commit subject line for each head

Regards, Frank

-- 
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
                                                  -- RFC 1925