Re: [PATCH] _git: fix gitk

[Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx>]

Simon Ruderich wrote:
> On Mon, Apr 25, 2011 at 01:49:48PM +0200, Frank Terbeck wrote:
>> Felipe Contreras wrote:
>>> On Mon, Apr 25, 2011 at 10:19 AM, Frank Terbeck wrote:
>> [...]
>>>> This is certainly better than what we did before (which was
>>>> "nothing"). Does `gitk' support all `git-log' options?
>>>
>>> It allows them, but some of them are ignored.
>>
>> Ah okay.  I've committed the patch then. Thanks!
>>
>> Regards, Frank
>
> The patch doesn't work for me. gitk <tab> just lists files names,
> gitk --<tab> lists no completions. git log <tab> works fine. _git
> is correctly loaded and other changes in it work fine. What am I
> doing wrong here?

The "#compdef" line changed.  Thus, you'll need to remove ~/.zcompdump
and restart zsh.

Regards, Frank