Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] more doubles

X-seq: zsh-workers 29310
From: Dan Nelson <dnelson@xxxxxxxxxxxxxxx>
To: Mikael Magnusson <mikachu@xxxxxxxxx>
Subject: Re: [PATCH] more doubles
Date: Tue, 17 May 2011 17:26:14 -0500
Cc: zsh-workers@xxxxxxx
In-reply-to: <1305660179-30039-1-git-send-email-mikachu@gmail.com>
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
References: <1305660179-30039-1-git-send-email-mikachu@gmail.com>

In the last episode (May 17), Mikael Magnusson said:
> Realized I should just search for any doubled word instead of trying to
> think up examples.  I hope nobody minds I didn't reflow comments.  :)
> 
> --- a/Doc/Zsh/builtins.yo
> +++ b/Doc/Zsh/builtins.yo
> @@ -406,7 +406,7 @@ with emulations to be set to their values in tt(sh).  tt(fni) then
>  calls tt(fno); because tt(fno) is also marked for sticky tt(sh)
>  emulation, no option changes take place on entry to or exit from it.
>  Hence the option tt(cshnullglob), turned off by tt(sh) emulation, will
> -be turned on within tt(fni) and remain on on return to tt(fno).  On exit
> +be turned on within tt(fni) and remain on return to tt(fno).  On exit
>  from tt(fno), the emulation mode and all options will be restored to the
>  state they were in before entry to the temporary emulation.

With my "Mister Grammar Person" hat on, I think the original was correct
here.  The first "on" being the state of cshnullglob, the second "on" being
part of the phrase "on return to fno".  The rest of the changes look good.

-- 
	Dan Nelson
	dnelson@xxxxxxxxxxxxxxx

Follow-Ups:
- Re: [PATCH] more doubles
  - From: Mikael Magnusson

References:
- [PATCH] more doubles
  - From: Mikael Magnusson

Messages sorted by: Reverse Date, Date, Thread, Author