Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: tab inserts literal tab instead of completing at beginning of line
- X-seq: zsh-workers 29363
- From: Mikael Magnusson <mikachu@xxxxxxxxx>
- To: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- Subject: Re: tab inserts literal tab instead of completing at beginning of line
- Date: Mon, 23 May 2011 19:11:22 +0200
- Cc: zsh-workers@xxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=S/LjlBFWyPOrS8T4WX2FgwOBjUFmLx4sHcntB1ATAVM=; b=s8izTVWrO4ILznwTpC1aKi4sqQs1WJqWf1WerG88YsYbMRmZh7RpK141eOyE+P0Dzo LwJSWT3yXN7a5nDFvrwx3imaC3RAfHcdynG/uKi7TIzKKAiQXCkksybaI57pf8r5c+64 i6bpHXq3FeHd0i2EsC2o5kVEItQtYEHbU232w=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=j12C/gwGwVpy/xF713mOFbG65jZYtkOLRAybbYplspiVzNws3+b9zg8LMnYivZ8Tca pev5bdDvzAI6JxUfVh+Xihr4MwquHE2f115HQ4cmuWvhBEDSU2RFFrRNRjGPv0UuggbX AGd3IF3VGom2Vg3VnWV8T+cFCVRvRIXs5mQFQ=
- In-reply-to: <110523095742.ZM15497@torch.brasslantern.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <110522192758.ZM718@torch.brasslantern.com> <1306119311-25431-1-git-send-email-mikachu@gmail.com> <110523095742.ZM15497@torch.brasslantern.com>
On 23 May 2011 18:57, Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> On May 23, 4:55am, Mikael Magnusson wrote:
> }
> } On 23 May 2011 04:27, Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> } > You're running into a strange combination of effects. The completion
> } > internals initialize compstate[insert]=tab only when an actual tab is
> } > pressed, but the effect of explicitly assigning compstate[insert]=tab
> } > inside a completion function is to change the final keystroke into a
> } > self-insert.
>
> I'm trying to decide if this is worth documenting.
>
> } A tangent, I was just staring at these tests, and the (|[[:blank:]]*)
> } thing that appears on both sides, shouldn't the asterisk be to the left
> } of the blank when the thing is to the left of the word?
>
> I think you're correct about that. There may be a few places that need
> that change.
I did a quick grep for the exact pattern that occurs here, and only
found it in _pids, and that already has the * on the right side.
> The two patches at the end of your message look fine if you want to
> commit one or the other (the "empty" one needs doc added, of course).
Okay, I'll commit the one without (the one with doesn't add it, it was
just on top of your patch). Is the patch to add "empty" pretty
uncontroversial if I add docs to it? I was a bit worried the subst +
length check might be a bit slow, but I ran a loop doing it 10000
times on a 1000 or so char long string and it only took 2 seconds or
so.
Is there some problem with zsh.org? I can't access www.zsh.org for the
mla to look up the number of my patch (gmail discards mailing lists
mails from yourself (sigh)), and iirc it was out a few days ago too.
--
Mikael Magnusson
Messages sorted by:
Reverse Date,
Date,
Thread,
Author