Re: Zsh 4.3.12: subshell in midnight commander: precmd: 15: bad file descriptor

[Peter Stephenson <Peter.Stephenson@xxxxxxx>]

On Mon, 18 Jul 2011 07:45:51 -0700
Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> So it's the calling shell rather than the called shell that is closing
> a descriptor that it shouldn't.

I don't think so: both lsof and sh -c 'pwd >&11' agree that the FD is
still open in the lower shell.

See if this fixes it.

Index: Src/exec.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/exec.c,v
retrieving revision 1.198
diff -p -u -r1.198 exec.c
--- Src/exec.c	23 Jun 2011 19:29:24 -0000	1.198
+++ Src/exec.c	18 Jul 2011 15:20:29 -0000
@@ -3008,11 +3008,17 @@ execcmd(Estate state, int input, int out
 		if (!checkclobberparam(fn))
 		    fil = -1;
 		else if (fn->fd2 > 9 &&
-			 (fn->fd2 > max_zsh_fd ||
-			  (fdtable[fn->fd2] != FDT_UNUSED &&
-			   fdtable[fn->fd2] != FDT_EXTERNAL) ||
-			  fn->fd2 == coprocin ||
-			  fn->fd2 == coprocout)) {
+			 /*
+			  * If the requested fd is > max_zsh_fd,
+			  * the shell doesn't know about it.
+			  * Just assume the user knows what they're
+			  * doing.
+			  */
+			 (fn->fd2 <= max_zsh_fd &&
+			  ((fdtable[fn->fd2] != FDT_UNUSED &&
+			    fdtable[fn->fd2] != FDT_EXTERNAL) ||
+			   fn->fd2 == coprocin ||
+			   fn->fd2 == coprocout))) {
 		    fil = -1;
 		    errno = EBADF;
 		} else {

-- 
Peter Stephenson <pws@xxxxxxx>            Software Engineer
Tel: +44 (0)1223 692070                   Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog