Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [(I)-foo] subscripting in _git
- X-seq: zsh-workers 29574
- From: Nikolai Weibull <now@xxxxxxxx>
- To: Mikael Magnusson <mikachu@xxxxxxxxx>
- Subject: Re: [(I)-foo] subscripting in _git
- Date: Thu, 21 Jul 2011 13:21:04 +0200
- Cc: zsh workers <zsh-workers@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=hgbr24LJE3o1cdn3QgngP21lzgNJ0KBY2rZovaFHBFk=; b=MaiMqiMe72gjsfCkray2jC2HegC4VBleCgu+SVZYepk/Vc9aFLD0m7uH/ucim2VdOo y8mvTq6OQcGG0392+Sw5MqLRSyxKkc7TZxg3uxuxeRm+J18qfh/ejIs5y5upQDF/mmaV ZxEg5pGjXuyYeZlHVYaZbrzqy59qSX6iXt6qA=
- In-reply-to: <CAHYJk3SrWNf56jG0tgu0kbNwCqo6t0Ke2Pyaej=mzRPMbCZqgA@mail.gmail.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <CAHYJk3SrWNf56jG0tgu0kbNwCqo6t0Ke2Pyaej=mzRPMbCZqgA@mail.gmail.com>
- Sender: nikolai.weibull@xxxxxxxxx
On Thu, Jul 21, 2011 at 12:32, Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
> I noticed while looking at _git-add that _git does a lot of this type of thing:
> if (( words[(I)-n|--dry-run] )); then
> that particular example is fine, but further down is this
> if [[ -n ${line[(I)-f|--force]} ]]; then
> which seems to have two problems, first it uses line instead of words,
> so it never matches.
If you check out the latest revision, however, this has been fixed. I
fixed it an hour or so ago. The correct pattern when checking for an
option processed by _arguments is if [[ -n ${opt_args[(I)-o|--option]}
]]; then …; fi.
There are, based on my checks, no other instances of the incorrect pattern.
Messages sorted by:
Reverse Date,
Date,
Thread,
Author