Re: Git commands or aliases first?

[Nikolai Weibull <now@xxxxxxxx>]

On Fri, Jul 22, 2011 at 13:58, Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
> On 22 July 2011 13:40, Nikolai Weibull <now@xxxxxxxx> wrote:
>> Hi!
>>
>> What is the desired tag order for Git commands and aliases?
>>
>> My conclusion is that the current behavior is incorrect.  My reasoning
>> is that git will prefer invoking a command over an alias with the same
>> name.
>>
>> Does anyone have a contradictory opinion, or should I merge this change?
>
> We could show aliases first, but leave out ones that are also
> commands? On the one hand, I would want to complete my aliases before
> the commands, on the other hand I usually make alias names short
> enough to not need completing. On the third hand it's configurable
> with group-order anyway, so either is fine with me :). Ie
> zstyle ':completion:*:git:*' group-order main-porcelain-commands

Yes, I realize that it’s configurable, but I’d prefer the default to
be what most users want.

Hm, perhaps __git_aliases_or_commands is doing this wrong.  Perhaps
adding the filtering that you suggest is the best way to do it.