Re: PATCH: (3/3) _git: re-add `user-commands' support again

[Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx>]

Nikolai Weibull wrote:
[...]
> Well, I’ve never guaranteed backwards compatibility in any of the
> releases of _git.  It’s always been a work in progress.  The
> user-commands style wasn’t something that I added, either.  Things are
> stabilizing now, but that also means that I would like to cut cruft
> like this.  Backwards compatibility isn’t in itself a strong enough
> argument for keeping it around.
>
> So, what exactly is the use case for user-commands?  Does it solve
> something that something else won’t solve with greater satisfaction?

It solves the case mentioned in the comment on top of the file.

I don't say that there isn't a better way. Now there is, with the _git
completion add-ons. But I don't think we should break compatibility
unless we need to. And the code is simple enough and doesn't break
performance or impair usability. So I'd say just throwing it away
doesn't bring any advantages. But it would bring the disadvantage of
breaking existing working setups for no good reason.

So I'd be against removing it.

Regards, Frank