Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: git --pretty completion, and (new) completion for npm



On Wed, Aug 3, 2011 at 17:05, Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
> 2011/8/3 Nikolai Weibull <now@xxxxxxxx>:
>> 2011/3/20 Johan Sundström <oyasumi@xxxxxxxxx>:
>>> On Sun, Mar 20, 2011 at 03:35, Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx> wrote:
>>>> Johan Sundström wrote:
>>>> > I took to adding documented completion for to the git completer for
>>>> syntax that
>>>> > is impossible to remember and hard to find in the man page; git log
>>>> --pretty
>>>> > (and whichever other commands support --pretty / --format) now covers the
>>>> whole
>>>> > lot except %w, which seemed like it would need a whole little state
>>>> machine in
>>>> > itself.
>>
>>>> Hm. This only works for stuff directly after the `=', doesn't it? As in:
>>>>
>>>> % git log -1 --pretty=%<tab>
>>
>>> Correct; enough to document what the properties are when there's just the
>>> one you're interested in (for me it's usually %H for the commit hash), but
>>> sub-ideal for longer formats.
>>>
>>> But not in:
>>>>
>>>> % git log -1 --pretty="%H %<tab>
>>>>
>>>> That would be pretty useful, don't you think?
>>
>>> It certainly would, but I fear my completion beard is not quite long enough
>>> yet for me to pull off that state machine, myself. :-)
>>
>> This was never applied.  Is anyone interested in having this added?
>> If so, it should be cleaned up and should probably add proper %w
>> handling and multiple-item handling.

> Not sure if this helps you,
> http://www.zsh.org/mla/workers/2011/msg00861.html but it also
> completes a bunch of %stuff after an assignment, so it seems similar.

Thanks, though I think I have a grip on how it should be done (I do
something similar already in parts of the git-config completion, I
believe).  I was, however, hoping that someone else would take a look
and do it :-).



Messages sorted by: Reverse Date, Date, Thread, Author