Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] Add completions for cryptsetup and twidge
- X-seq: zsh-workers 29692
- From: Mikael Magnusson <mikachu@xxxxxxxxx>
- To: Daniel Friesel <derf@xxxxxxxxxxxxxxx>
- Subject: Re: [PATCH] Add completions for cryptsetup and twidge
- Date: Tue, 16 Aug 2011 21:18:11 +0200
- Cc: zsh-workers@xxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Cj6naxY6xaAAgWTvOzmhxJfmZQS9vPaVr6s6jyGtuIM=; b=j1ZMY4E1x4DUa+fVcuk0ULbV0wj7ya/EGjc910X2wmCEbCNrR1KKD9SdpO7Gj2EXzr /UrSo4GylYUy62h9TN/oU/Q6NCKr3iLdQCdQhZc9Nc3K8T4p2nE8aruIHD/6+MPnsDL7 hXaIck3y2saf1uwT87RSWu7TdbLD3Rluo3OVE=
- In-reply-to: <20110816183921.GA10577@derf.homelinux.org>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20110816183921.GA10577@derf.homelinux.org>
On 16 August 2011 20:39, Daniel Friesel <derf@xxxxxxxxxxxxxxx> wrote:
> Hi,
>
> could someone merge these into the repo, if they're okay?
In _cryptsetup you don't redefine _cryptsetup() like you do in _twidge
(it's better to redefine it to avoid redefining all the helper
functions every time), and in _twidge you forget to pass "$@".
--
Mikael Magnusson
Messages sorted by:
Reverse Date,
Date,
Thread,
Author