Re: pcre test failures

[Peter Stephenson <Peter.Stephenson@xxxxxxx>]

On Wed, 26 Oct 2011 19:49:17 +0900
Jun T. <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
> [2] If --enable-pcre is specified for ./configure
> but the pcre-config command is not installed on the host,
> then virtually empty pcre.so is built.
> I guess this is the second case in the Vin's post.
> pcre-config (and pcre.h etc.) are in pcre-dev (or similar) package in
> many Linux distros. Once I installed this package it worked fine
> (tested on Fedora14).
> 
> I think it would be better to modify configure.ac so that enable-pcre
> is reset to "no" if pcre-config command is not found. 

Yes, I've been trying to avoid problems like this.  In general, it's
much better for a module not to be built than to load and announce it
can't do anything, which is no use to anyone.

Index: Src/Modules/pcre.mdd
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/pcre.mdd,v
retrieving revision 1.4
diff -p -u -r1.4 pcre.mdd
--- Src/Modules/pcre.mdd	20 Jun 2007 20:59:18 -0000	1.4
+++ Src/Modules/pcre.mdd	26 Oct 2011 12:45:49 -0000
@@ -1,5 +1,5 @@
 name=zsh/pcre
-link=`if test x$enable_pcre = xyes; then echo dynamic; else echo no; fi`
+link=`if test x$enable_pcre = xyes && (pcre-config --version >/dev/null 2>/dev/null); then echo dynamic; else echo no; fi`
 load=no
 
 autofeatures="b:pcre_compile b:pcre_study b:pcre_match"


-- 
Peter Stephenson <pws@xxxxxxx>            Software Engineer
Tel: +44 (0)1223 692070                   Cambridge Silicon Radio Limited
Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, UK


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog