Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: PATCH: Update VCS_INFO_detect_svn for Subversion 1.7
- X-seq: zsh-workers 29906
- From: Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx>
- To: "Akinori MUSHA" <knu@xxxxxxxxxxxx>
- Subject: Re: PATCH: Update VCS_INFO_detect_svn for Subversion 1.7
- Date: Wed, 09 Nov 2011 17:30:54 +0100
- Cc: zsh-workers@xxxxxxx
- In-reply-to: <86sjlxoows.knu@iDaemons.org> (Akinori MUSHA's message of "Wed, 09 Nov 2011 14:17:23 +0900")
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <86sjlxoows.knu@iDaemons.org>
It seems like I was missing something Phil put into the `_get_data_'
function: It is able to handle nested working copies. As in: /foo/bar is
the checkout of one repository and /foo/bar/baz/bob being the checkout
of another.
My glob idea doesn't catch that properly.
The matter has been discussed on IRC for a while and I've come to the
conclusion that applying Akinori's original patch is probably the best.
It does double the work a little, but I think it should work in almost
all cases.
So, thanks for that.
Regards, Frank
Akinori MUSHA wrote:
[...]
> Index: Functions/VCS_Info/Backends/VCS_INFO_detect_svn
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Functions/VCS_Info/Backends/VCS_INFO_detect_svn,v
> retrieving revision 1.3
> diff -u -r1.3 VCS_INFO_detect_svn
> --- Functions/VCS_Info/Backends/VCS_INFO_detect_svn 11 Feb 2011 07:05:09 -0000 1.3
> +++ Functions/VCS_Info/Backends/VCS_INFO_detect_svn 9 Nov 2011 05:14:03 -0000
> @@ -7,5 +7,5 @@
> [[ $1 == '--flavours' ]] && return 1
>
> VCS_INFO_check_com ${vcs_comm[cmd]} || return 1
> -{ [[ -f ".svn/entries" ]] || [[ -f ".svn/format" ]] } && return 0
> -return 1
> +vcs_comm[detect_need_file]="entries format"
> +VCS_INFO_bydir_detect '.svn' || return 1
Messages sorted by:
Reverse Date,
Date,
Thread,
Author