Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
PATCH: Restore `LC_ALL' when setting `LANG'
- X-seq: zsh-workers 30079
- From: Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx>
- To: 654225@xxxxxxxxxxxxxxx
- Subject: PATCH: Restore `LC_ALL' when setting `LANG'
- Date: Tue, 03 Jan 2012 16:26:44 +0100
- Cc: Michael Prokop <mika@xxxxxxxxxx>, mbj@xxxxxxxxxxx, zsh-workers@xxxxxxx
- In-reply-to: <87boqk95we.fsf@ft.bewatermyfriend.org> (Frank Terbeck's message of "Tue, 03 Jan 2012 16:12:33 +0100")
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20120102132718.GA12143@gatsby.mbjnet.dk> <87fwfyb2if.fsf@ft.bewatermyfriend.org> <20120102154714.GA20663@gatsby.mbjnet.dk> <87wr9a9ely.fsf@ft.bewatermyfriend.org> <20120103111049.GA5673@gatsby.mbjnet.dk> <87sjjw98yl.fsf@ft.bewatermyfriend.org> <87k458974e.fsf@ft.bewatermyfriend.org> <2012-01-03T15-59-18@devnull.michael-prokop.at> <87boqk95we.fsf@ft.bewatermyfriend.org>
(Cc:ing Upstream)
When setting LANG, zsh sets LC_ALL and then goes on to restore all
interesting LC_* values after that. Up to now, it did not restore LC_ALL
itself, though.
That could lead to trouble when setting LC_ALL=something-utf8-ish and
after that LANG=something-non-utf8.
This was reported in Debian bugreport #654225:
<http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=654225>
A recipe to reproduce the issue is here:
<http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=654225#65>
I think the patch below fixes the issue correctly, by restoring LC_ALL
from its parameter along the way with all the other LC_* values zsh
cares about.
(FWIW, the test-suite still passes with this change.)
Regards, Frank
---
Src/params.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/Src/params.c b/Src/params.c
index 446cccc..6d98b8e 100644
--- a/Src/params.c
+++ b/Src/params.c
@@ -3780,6 +3780,9 @@ static struct localename {
#ifdef LC_TIME
{"LC_TIME", LC_TIME},
#endif
+#ifdef LC_ALL
+ {"LC_ALL", LC_ALL},
+#endif
{NULL, 0}
};
--
1.7.8.rc3.17.gf56ef1
Messages sorted by:
Reverse Date,
Date,
Thread,
Author