Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH 2/3] Completion/Unix/Command/_git: fix shortlog completer
- X-seq: zsh-workers 31294
- From: Ramkumar Ramachandra <artagnon@xxxxxxxxx>
- To: Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH 2/3] Completion/Unix/Command/_git: fix shortlog completer
- Date: Sat, 20 Apr 2013 22:43:24 +0530
- Cc: Nikolai Weibull <now@xxxxxxx>, ZSH Workers <zsh-workers@xxxxxxx>, Frank Terbeck <bewater@xxxxxxxxxxxxxxxxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=GiPr4GOzDqJvwE+hMlhu0p/L6NWOzBa5wbNcm6eW9sk=; b=j8A9KdXFVrTvW98zxiF+lXmL7AVFC4e+TaYZ/N5JJhEiXDEhjJ3MkTLoG0SlhZSo+m dYBlx6ViQa0jeGWxF9T6EDRo9LrPz3UAs5C502QKVAHpYRv+ffOiqp6S4YK+u2AzpgYF d+2+mfqUJ27piyEw8C93rUJcHXa/8Ldo1H9WFD3C0tbsHvxz2LBowYXnj1ksnlzYcNpl dmi1EnDGn7GyWMe7hF52aAxOiPjbHc+UzNFAq5Q1L4i7nWnZ9irpd1H03VV6g+Z54BlT 4zE+ZORp7DkDekUdv8CrhOM9En4DnIk9WY7eaZ6j9m34Mpss//I1UGhTcbr7GyMbMI0W dgZQ==
- In-reply-to: <87zjwt5jkw.fsf@ft.bewatermyfriend.org>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <1366462573-15545-1-git-send-email-artagnon@gmail.com> <1366462573-15545-3-git-send-email-artagnon@gmail.com> <CADdV=MtT-e8ctrsgmavfFYPzP89h-nAdL9_OOD_rFJvPD=VkSg@mail.gmail.com> <87zjwt5jkw.fsf@ft.bewatermyfriend.org>
[-CC: Clint Adams; his email address seems to be bouncing email]
Frank Terbeck wrote:
> So, do we take this patch as well or do we want to spend time on
> fleshing out the helper function? Both would work for me, to be
> honest. :)
You can apply this as-is if you like: I'll submit a patch factoring
out this code into a fresh function soon. In the meantime, can
someone tell me how to test _git quickly? I don't want to have to
re-compile, install, and start a new shell to test a small change.
Besides, there are plenty of other related problems. Off the top of my head:
1. There's only some small logic for invoking __git_committish_range.
What happens to other kinds of revision specs? Think completions for
stuff like :/quuxery, pu@{1}^2~300, ..next, bar@{2 days ago},
v1.7-679-g3bee7fb etc. It might be too hard to support everything,
but we can certainly improve over just a <since>..<until> range.
2. log, shortlog, and blame should use rev-spec-or-file (a generalized
version of commit-range-or-file).
3. reset, checkout, and grep should use treeish-or-file.
Thanks.
Messages sorted by:
Reverse Date,
Date,
Thread,
Author