Re: [PATCH] Update make completion with gnu options

["Jun T." <takimoto-j@xxxxxxxxxxxxxxxxx>]

A few comments/questions on the recent patches for _make.

[1] I think the following options can be repeated

   -C   -I   -o   -W  (and their --long-option versions)

and '-C' etc. should be replaced by '*-C' in option_spec.
A simple patch for this will be posted in a separate message.

With the patch, 

   $ make -C /foo/bar -C <tab>

will correctly complete the subdirectories of /foo/bar.

[2] Other options can't be repeated. It may be better to replace, for example,

{-B,--always-make}'[Unconditionally make all targets]'

by

'(-B --always-make)'{-B,--always-make}'[Unconditionally make all targets]'

[3] If I set

zstyle ':completion:*:descriptions' format '%B%d%b'

and complete directory after -C or -I, the description I get is not 'directory'
but 'file'. It seems that this can be 'fixed' by replacing '_file' by 
'_path_files' at line 209, but I must say I haven't yet understood how/where
the description is determined.

[4] At line 156, _pick_variant is used as

_pick_variant -r is_gnu gnu=GNU unix -v -f

Why the last '-f' is necessary here?