Re: [PATCH 15/16] _git: git rm: make git rm --cached work as intended

[Nikolai Weibull <now@xxxxxxx>]

On Sun, Jul 28, 2013 at 6:22 PM, Øystein Walle <oystwa@xxxxxxxxx> wrote:
> From: m0viefreak <m0viefreak.cm@xxxxxxxxxxxxxx>
>
> While limiting the completion to __git_changed-in-index_files
> makes perfect sense for "git diff", it is wrong to use for
> "git rm", because it prevents it from completing files present in
> HEAD. Giving --cached to git rm is supposed to
> "just remove it from the index, keep the working tree copy"
> and is in no way related to the file needing to be
> modified in the index in the first place.

If I understand --cached, it’s exactly like you described, and if you
specify --cached, you only want files actually modified in the index
to be completed.  I may be wrong, but please clarify, as you seem to
be stating a tautology.