Re: 5.0.2-test-2 is available

[Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>]

On Dec 2,  4:08pm, Peter Stephenson wrote:
}
} I'm getting with make on Cygwin
} 
} sh: colcrt: command not found

Out of curiosity, do you have yodl installed on Cygwin?  If not, how are
you even getting this far in the build process?  zshbuiltins.1 should
not exist, so the dependency for help.txt can't be satisfied, and perl
should never even be run ...?

If you don't have yodl, and zshbuiltins.1 is coming from the doc tarball,
then as noted in earlier email help.txt should also be in the doc tarball
and needs to be newer than zshbuiltins.1 so that it's not rebuilt.

If you do have yodl and are not using the doc tarball, then our previous
position has been that developers are responsible for making sure they have
all the tools to complete the build from scratch on whatever platform.

However, if we want to take the position that failing to rebuild help.txt
is inconsequential, then just remove the "false;" at the end of the rule
as in the following diff:


diff --git a/Doc/Makefile.in b/Doc/Makefile.in
index 50e210f..be66862 100644
--- a/Doc/Makefile.in
+++ b/Doc/Makefile.in
@@ -191,7 +191,7 @@ help.txt: zshbuiltins.1
 	@-rm -f $(sdir)/help.txt $(sdir)/help/*
 	perl $(sdir_top)/Util/helpfiles \
 	    $(sdir)/zshbuiltins.1 $(sdir)/help $(sdir)/help.txt \
-	    || { rm -f $(sdir)/help.txt $(sdir)/help/*; false; }
+	    || rm -f $(sdir)/help.txt $(sdir)/help/*
 
 $(MAN): zmacros.yo zman.yo